-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve usability of Project & Service objects #305
Comments
cc @glours I know we talked about this before around another Compose PR, so you might remember some other cases we should track here |
Users should add new elements to this kind of Map with the helper Anyway we can create a generic function for that as Golang 1.19 is out. |
Hello guys, sorry for joining the discussion here 🙏 . how about on |
Description
The
Project
andService
objects returned by this library oftenconfuse users because certain fields are not always initialized.
For example,
CustomLabels
(amap[string]string
) will benil
on each
Service
.Potential Solutions
NewProject
andNewService
constructors that initializeall fields consistently
AddCustomLabel
that internally handleinitialization lazily
Related Issues
docker/compose#9808
The text was updated successfully, but these errors were encountered: