Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Path type in the File module #2770

Open
harendra-kumar opened this issue Jul 9, 2024 · 1 comment · May be fixed by #2869
Open

Use the Path type in the File module #2770

harendra-kumar opened this issue Jul 9, 2024 · 1 comment · May be fixed by #2869
Assignees
@adithyaov
Labels
api:deprecating Deprecates an API
Milestone
0.11.0

Comments

@harendra-kumar
Copy link
Member

harendra-kumar commented Jul 9, 2024 •
edited
Loading

  • Copy File module to FileIO, remove the deprecated functions from FileIO.
  • Change FilePath to Path in FileIO.
  • Deprecate the old File module
@harendra-kumar harendra-kumar added the api:deprecating Deprecates an API label Jul 9, 2024
@harendra-kumar harendra-kumar added this to the 0.11.0 milestone Jul 9, 2024
@harendra-kumar
Copy link
Member Author

harendra-kumar commented Jul 20, 2024 •
edited
Loading

For openFile we can open an fd directly using the system call and use fdToHandle to convert it to Handle. We do a similar thing in the Linux fsevent module.

@adithyaov adithyaov linked a pull request Oct 30, 2024 that will close this issue
Add File internals that work directly with Path #2869
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adithyaov adithyaov

Labels
api:deprecating Deprecates an API
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

Add File internals that work directly with Path composewell/streamly
2 participants
@harendra-kumar @adithyaov