Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses in relations.ts should be case-insensitive #765

Open
kevincheng96 opened this issue Jun 21, 2023 · 2 comments
Open

Addresses in relations.ts should be case-insensitive #765

kevincheng96 opened this issue Jun 21, 2023 · 2 comments
Assignees
@Arveymenon
Labels
bug Something isn't working

Comments

@kevincheng96
Copy link
Contributor

Spider currently expects addresses in relations.ts to be all lower case. We should make it case-insensitive.

e.g.

  '0xDbcd5BafBAA8c1B326f14EC0c8B125DB57A5cC4c': {
    artifact: 'contracts/ERC20.sol:ERC20',
  },

will not work right now
@kevincheng96 kevincheng96 added the bug Something isn't working label Jun 21, 2023
@Arveymenon
Copy link

Hi @kevincheng96,
Can you please assign this bug to me.
And review this PR.
#807

@kevincheng96
Copy link
Contributor Author

Thanks @Arveymenon. Left a comment in your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arveymenon Arveymenon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevincheng96 @Arveymenon