Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on "FilterFragSpectra" #30

Open
jsaintvanne opened this issue Nov 20, 2019 · 1 comment
Open

Error on "FilterFragSpectra" #30

jsaintvanne opened this issue Nov 20, 2019 · 1 comment
Labels

Comments

@jsaintvanne
Copy link

jsaintvanne commented Nov 20, 2019

Just have an error when I select "remove peaks" with YES when I process msPurity.filterFragSpectra tool

Error in names(x) <- value : 
  attribut 'names' [2] doit être de même longueur que le vecteur [0]
Calls: <Anonymous> ... loop_apply -> <Anonymous> -> .fun -> colnames<- -> colnames<-

Thomas spotted me these lines where filtered peaks are automatically select but it could be great for users to see directly how many lines we selected (differences between f4f and after filter pa@grped_df)

@Tomnl
Copy link
Member

Tomnl commented Nov 20, 2019

Thanks @jsaintvanne.

I will look into this. Probably needs a check if the filtering removes all peaks.

For the time being - as you mentioned, the lines here will mean that if the filterFragSpectra function has been used the flagged peaks will be not be including for averaging anyway.

@Tomnl Tomnl added the bug label Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants