Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Disable V2 linter #14927

Closed
HappySeaFox opened this issue Dec 25, 2022 · 3 comments
Closed

[question] Disable V2 linter #14927

HappySeaFox opened this issue Dec 25, 2022 · 3 comments
Labels
question Further information is requested

Comments

@HappySeaFox
Copy link
Contributor

What is your question?

Hi. Previously I could disable V2 linter, but now it seems impossible to do. Is there other way to disable it, or re-enable this possibility to disable linter for limited use-case like bugs in conan?

Why do I need this? My recipe (#14871) is blocked by one of it since September (#13000, #13159), and now I realized that there is another one in CMakeDeps (conan-io/conan#12600) that could possibly block it for a few months more. I'd like to just update the version of my recipe and leave it V1-compliant only. V2 migration could be done later.

@HappySeaFox HappySeaFox added the question Further information is requested label Dec 25, 2022
@SpaceIm
Copy link
Contributor

SpaceIm commented Dec 25, 2022

Current v2 linter doesn't enforce full conan v2 migration. You can keep old build helpers & generators for the moment (conans.tools.CMake class, cmake & cmake_find_package generators), and only translate few legacy functions to copy, get, rmdir, rm, is_msvc, is_apple_os, etc, and also ConanFile & ConanInvalidConfiguration import.

@uilianries
Copy link
Member

Hello and Merry Christmas @HappySeaFox! Indeed is not possible to disable the linter and it can be boring in some cases. Unfortunately, we would not be able to find a git diff to integrate to the linter, to check if it's a bump version only and avoid the linter.

There is a hooks which checks when someone tries to disable pylint: https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#kb-h072-pylint-execution

Plus, there is a good reference about those new tools to be used instead of the legacy one: https://github.com/conan-io/conan-center-index/blob/master/docs/v2_linter.md

Like SpaceIm said, most of errors you just need to replace some imports.

@HappySeaFox
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants