Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpcap: add support for dbus, libnl and rdma #23383

Merged
merged 8 commits into from
Sep 27, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Apr 5, 2024

Build log with all options enabled on Linux: https://gist.github.com/valgur/bb1ff3fd0ca5045a378ddd228c5588b3

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

AbrilRBS
AbrilRBS previously approved these changes Sep 23, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that this took so long to get reviewed, looks good to me! :)

Thanks a lot for also including a full compilation log, truly appreciated!

@AbrilRBS AbrilRBS self-assigned this Sep 23, 2024
@AbrilRBS
Copy link
Member

@valgur there are some conflicts, please take a look so we can merge this!

AbrilRBS
AbrilRBS previously approved these changes Sep 23, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking for further review. Thank you for your update! libpcap is a powerful library!

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member

@valgur I just tried to build locally, but using the official Docker image conanio/gcc11-ubuntu16.04:2.7.0 and it fails to build:

libpcap-1.10.4-linux-all-options.log

The error occurred because libpcap was not capable to find those dependencies via pkg-config. The PkgConfigDeps is missing in the recipe. Furthermore, there is a new bug in Conan client that does not allow us renaming the .pc for libnl::nl-genl component, so libpcap is not capable to find the expected pc file as well.

The commit 9271f24 fixes the situation by add PkgConfigDeps and renaming the generated .pc file, so we do not patch pcap directly (much cheaper).

libpcap-1.10.4-linux-pkgconfdeps.log

Please, consider using those docker images in the future, when providing the build lob. It did not fail for you, as you system is well configured, having all dependencies installed already.

@uilianries
Copy link
Member

UPDATE: I just checked AUR and indeed the expected .pc file for nl-genl is libnl-genl-3.0.pc

https://archlinux.org/packages/core/x86_64/libnl/

I'll open a PR fixing it, so we do not need this current workaround by renaming the .pc file here.

@conan-center-bot

This comment has been minimized.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member

Depends on #25380 first.

It will fix the correct pkg-config missing for libnl when active with libpcap.

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

The PR #25380 has been merged. I just rebased this PR.

@uilianries uilianries self-requested a review September 24, 2024 15:15
@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

Need extra PR: #25386

@valgur
Copy link
Contributor Author

valgur commented Sep 24, 2024

LGTM. Thank you for the libnl fix, @uilianries!

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Now libpcap is really consuming Conan dependencies for those new options:

lipcap-1.10.4-linux-shared.log
lipcap-1.10.4-linux-static.log

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 10 (fc9180f642c5108e06f99dc96d94a5d1aa76687c):

  • libpcap/1.9.1:
    Built 16 packages out of 22 (All logs)

  • libpcap/1.10.4:
    Built 20 packages out of 22 (All logs)

  • libpcap/1.10.0:
    Built 18 packages out of 22 (All logs)

  • libpcap/1.10.1:
    Built 20 packages out of 22 (All logs)

@conan-center-bot conan-center-bot merged commit a005c20 into conan-io:master Sep 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants