-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opentelemetry-cpp: enable cross-compilation of shared libraries and dependencies #25028
base: master
Are you sure you want to change the base?
Conversation
…t vars from aggregating on cross-compiles
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reverts commit 7eba3df.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
In order to move forward we need to understand what it is trying to fix! Can you provide details of a scenario where it fails to build without this proposed patch? Thanks!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 7 (
Conan v2 pipeline ✔️
All green in build 7 ( |
@jcar87 Details added, ready for review. |
Summary
Changes to recipe: opentelemetry-cpp/1.14.2
Motivation
Cross-compiling this package with full shared library support for dependencies results in build failure.
Closes #25054
Details
Made sure the virtual build and run scopes are separate so that the appropriate libraries and executables are found in the cross-compilation case instead of getting confused and selecting the wrong ones. Also tweak the sources to make cmake link libraries public for shared library targets so that consumers and can link with the libraries appropriately.