Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[package] qt/5: Non-canonical cmake names #5019

Closed
ruilvo opened this issue Mar 23, 2021 · 4 comments
Closed

[package] qt/5: Non-canonical cmake names #5019

ruilvo opened this issue Mar 23, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@ruilvo
Copy link
Contributor

ruilvo commented Mar 23, 2021

Package and Environment Details (include every applicable attribute)

  • Package Name/Version: qt/5

I was trying to write a recipe for Kirigami (#5015) and in Kirigami's CMakeLists.txt one can read find_package(Qt5 ..., which is a valid way to look for Qt in the official docs for CMake usage. In the recipe I'm trying to make I used generators = "cmake", "cmake_find_package_multi" and then I got this error:

CMake Error at CMakeLists.txt:30 (find_package):
  Could not find a package configuration file provided by "Qt5" (requested
  version 5.14.0) with any of the following names:

    Qt5Config.cmake
    qt5-config.cmake

  Add the installation prefix of "Qt5" to CMAKE_PREFIX_PATH or set "Qt5_DIR"
  to a directory containing one of the above files.  If "Qt5" provides a
  separate development package or SDK, be sure it has been installed.

(yes, I know conan doesn't have 5.14.0, but that's not the point)

See how it looks for qt5-config.cmake? Well, the files conan offers are qt-config.cmake, qt-config-version.cmake, and qtTargets.cmake.

So I guess this is something in need of fixing.

@ruilvo ruilvo added the bug Something isn't working label Mar 23, 2021
@ruilvo
Copy link
Contributor Author

ruilvo commented Mar 23, 2021

I also noticed set_property(TARGET qt::qt in the file qt-config.cmake, and the targets Qt uses are like Qt5::Core and etc...

@ericLemanissier
Copy link
Contributor

this is blocked by #4529

@ericLemanissier
Copy link
Contributor

This is fixed by #5691

@ruilvo
Copy link
Contributor Author

ruilvo commented Jun 16, 2021

Thanks @ericLemanissier. I wrote that on other bugs and forgot about mine!!! hahah
Now we can start doing recipes for the KDE stuff!!

@ruilvo ruilvo closed this as completed Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants