Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Expose is_apple_os & to_apple_arch in conan.tools.apple #11865

Closed
1 task done
SpaceIm opened this issue Aug 14, 2022 · 6 comments · Fixed by #11915
Closed
1 task done

[feature] Expose is_apple_os & to_apple_arch in conan.tools.apple #11865

SpaceIm opened this issue Aug 14, 2022 · 6 comments · Fixed by #11915
Assignees
Milestone

Comments

@SpaceIm
Copy link
Contributor

SpaceIm commented Aug 14, 2022

is_apple_os is widely used in conan-center-index (almost 10% of recipes), it prevents their full migration to conan v2.

@jcar87 jcar87 added this to the 1.52 milestone Aug 15, 2022
@jcar87 jcar87 self-assigned this Aug 15, 2022
@lasote
Copy link
Contributor

lasote commented Aug 18, 2022

The usage of to_apple_arch is way lower than is_apple_os, but we have indeed assigned to 1.52 to take a look at it.

@pgeler
Copy link

pgeler commented Aug 19, 2022

wish is_apple_os can be addressed differently than breaking those 10% 🤦

@jcar87
Copy link
Contributor

jcar87 commented Aug 19, 2022

wish is_apple_os can be addressed differently than breaking those 10% 🤦

Hi @pgeler - we are making every effort to prevent breakages for both Conan and Conan Center users during the staggered transition to Conan 2. If you could kindly provide a report of issues caused by the the lack of is_apple_os in the conan.tools.apple, I'll make sure to address this swiftly.

@pgeler
Copy link

pgeler commented Aug 19, 2022

@jcar87 it did break packages in 1.51.3 this one is an example conan-io/conan-center-index#12335, I was struggling around last night

@jcar87
Copy link
Contributor

jcar87 commented Aug 19, 2022

Hi @pgeler - thank you. Apologies for the inconvenience, after noticing the issue with a small number of recipes we have moved to correct this - it should now work properly even on Conan 1.51.3. Please let us know if this is not the case.

@memsharded
Copy link
Member

#11915 merged, will be in 1.52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants