Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit behaviour of revision_mode=scm when export or exports_sources are modified #12069

Closed
czoido opened this issue Sep 9, 2022 · 2 comments
Closed

Revisit behaviour of revision_mode=scm when export or exports_sources are modified #12069

czoido opened this issue Sep 9, 2022 · 2 comments
Assignees
@czoido
Labels
type: look into
Milestone
2.0.0-beta4

Comments

@czoido
Copy link
Contributor

czoido commented Sep 9, 2022

Discuss what is the desired behaviour in the case of this test for Conan 2.0:

  • Create a package with scm revision mode. The recipe revision is the hash of the last commit
  • Modify the recipe
  • Create again, the revision stays the same but the test checks that the changes are applied in the recipe
@czoido czoido added this to the 2.0.0-beta4 milestone Sep 9, 2022
@memsharded
Copy link
Member

Lets raise an error if the revision_mode="scm" and the export is dirty

@czoido czoido mentioned this issue Oct 7, 2022
Merged
@memsharded
Copy link
Member

Closed by #12267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@czoido czoido

Labels
type: look into
Projects
None yet
Milestone
2.0.0-beta4
Development

No branches or pull requests
2 participants
@czoido @memsharded