Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Update distro requirement to <=1.8.0 #13123

Closed
1 task done
geochip opened this issue Feb 14, 2023 · 2 comments · Fixed by #13124
Closed
1 task done

[feature] Update distro requirement to <=1.8.0 #13123

geochip opened this issue Feb 14, 2023 · 2 comments · Fixed by #13124
Assignees
@memsharded

Comments

@geochip
Copy link
Contributor

geochip commented Feb 14, 2023

What is your suggestion?

Latest version of Distro is 1.8.0, it would be good to support this in requirements.txt as breaking changes seem to be few,
see https://github.com/python-distro/distro/blob/master/CHANGELOG.md

Have you read the CONTRIBUTING guide?

  • I've read the CONTRIBUTING guide
@memsharded memsharded self-assigned this Feb 14, 2023
@memsharded
Copy link
Member

Hi @geochip

Thanks for the suggestion.
Sounds reasonable, do you want to do a PR yourself to test it and see if something breaks?

@geochip
Copy link
Contributor Author

geochip commented Feb 14, 2023

Hi @memsharded.

Sounds reasonable, do you want to do a PR yourself to test it and see if something breaks?

I will try.

@geochip geochip mentioned this issue Feb 14, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Distro latest version is 1.8.0 geochip/conan
2 participants
@memsharded @geochip