[bug] The root path is applied twice for editable packages

[fredizzimo]

Environment details

Conan release/2.0 branch

Steps to reproduce

#13983 tries to fix editable packages with a root. But the fix does not quite work, since root is applied twice for the main node.

This can be seen by changing the test to

def test_editable_folders_root():
    """ Editables with self.folders.root = ".." should work too
    """
    c = TestClient()
    sub1 = textwrap.dedent("""
        from conan import ConanFile

        class Pkg(ConanFile):
            name = "pkg"
            version = "0.1"
            def layout(self):
                self.folders.root = ".."
                self.folders.build = "mybuild"
                self.cpp.build.libdirs = ["mylibdir"]

            def generate(self):
                self.output.info(f"PKG source_folder {self.source_folder}")
        """)
    sub2 = textwrap.dedent("""
        from conan import ConanFile

        class Pkg(ConanFile):
            requires = "pkg/0.1"
            def generate(self):
                pkg_libdir = self.dependencies["pkg"].cpp_info.libdir
                self.output.info(f"PKG LIBDIR {pkg_libdir}")
        """)
    c.save({"sub1/conanfile.py": sub1,
            "sub2/conanfile.py": sub2})
    c.run("editable add sub1")
    c.run("install sub2")
    libdir = os.path.join(c.current_folder, "mybuild", "mylibdir")
    assert f"conanfile.py: PKG LIBDIR {libdir}" in c.out
    assert f"conanfile.py: PKG source_folder {c.current_folder}" in c.out

The source folder becomes the parent of c.current_folder and the test fails.

The same thing can be observed when changing root to root for example, then all the paths gets root/root instead of just root

Here's the explanation of what happens:

conan/conans/client/installer.py

Line 349 in 4f97fea

conanfile.folders.set_base_folders(base_path, output_folder)

calls set_base_folders, which already sets the root as can be seen here

conan/conans/model/layout.py

Lines 77 to 78 in 4f97fea

	base_folder = conanfile_folder if self.root is None else \
	os.path.normpath(os.path.join(conanfile_folder, self.root))

, so it gets applied twice.

When I was trying to fix the bug before I saw the fix in #1398 I just commented out the following lines (I have no idea why they would need to be there, and they caused the root to be set back to the wrong value)

conan/conans/client/installer.py

Lines 362 to 365 in 4f97fea

	conanfile.folders.set_base_package(output_folder or base_path)
	conanfile.folders.set_base_source(base_path)
	conanfile.folders.set_base_build(output_folder or base_path)
	conanfile.folders.set_base_generators(output_folder or base_path)

Another thing that seems to work is to move

conan/conans/client/installer.py

Lines 347 to 348 in 4f97fea

	base_path = base_path if conanfile.folders.root is None else \
	os.path.normpath(os.path.join(base_path, conanfile.folders.root))

down below the set_base_folders call.

But I wonder if that's really correct, should the root really be the same for all the nodes? I don't know the codebase and the Conan internals well enough to answer that.

Logs

No response

[AbrilRBS]

Hi @fredizzimo thanks a lot for your report, we appreciate it (Doing such a good investigation on your part proved extremely useful in tracking the issue down too 🫶)

You were spot on with the root cause too! I have simplified the code a bit and will add some more tests to this section before merging :)

[memsharded]

Closed by #14109, will be in 2.0.7 soon, thanks again for reporting!