Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Should XCRun use the conanfile's build env? #14297

Closed
1 task done
sfackler opened this issue Jul 13, 2023 · 5 comments · Fixed by #14326
Closed
1 task done

[question] Should XCRun use the conanfile's build env? #14297

sfackler opened this issue Jul 13, 2023 · 5 comments · Fixed by #14326
Assignees
Milestone

Comments

@sfackler
Copy link
Contributor

What is your question?

I realized that #14195 doesn't fully solve the issues I was having when doing a Linux -> macOS cross build, since XCRun still assumes that xcrun is in the ambient PATH. I can work around it without too much trouble by just doing:

with VirtualBuildEnv(self).vars().apply():
    fix_apple_shared_install_name(self)

but ideally the tool would apply the build env internally.

Have you read the CONTRIBUTING guide?

  • I've read the CONTRIBUTING guide
@memsharded memsharded self-assigned this Jul 16, 2023
@memsharded memsharded added this to the 2.0.9 milestone Jul 16, 2023
@memsharded
Copy link
Member

Hi @sfackler

I just realized that XCRun() is not fully applying Conan profiles PATH env-var.
If something like this:

[buildenv]
PATH+=(path)/path/to/my/cross/xcrun

That would be a good solution, wouldn't it?

Note I don't think with VirtualBuildEnv(self).vars().apply(): is a good solution, doesn't look great.

@sfackler
Copy link
Contributor Author

I think you'd probably want the whole build env applied for things like LD_LIBRARY_PATH.

@memsharded
Copy link
Member

Yes, exactly, I am trying to do #14326, so whatever you inject in the profile is used to run xcrun.

@memsharded
Copy link
Member

#14326 was merged, it will be in next 2.0.10 release

@sfackler
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants