Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy should have the option to log all files matched/copied by a call #4690

Closed
sigiesec opened this issue Mar 7, 2019 · 3 comments · Fixed by #15513
Closed

copy should have the option to log all files matched/copied by a call #4690

sigiesec opened this issue Mar 7, 2019 · 3 comments · Fixed by #15513
Assignees
Milestone

Comments

@sigiesec
Copy link
Contributor

sigiesec commented Mar 7, 2019

A frequent issue we have is that copy (particularly during package) does not match the files it is intended to match, but often too many files are packaged. To allow to investigate this better, it would be good if, optionally, the files matched by each call should be logged. Currently, only the overall set of files matched by all call options, and the output is aggregated by extension if there are more than a few files.

@uilianries
Copy link
Member

Hi @sigiesec !

For now you could use conan get to inspect the manifest file and check what was copied to the package folder.

conan get -p 35437353b857392790f3121d268b1db3fb9a09b0 zlib/1.2.11@conan/stable conanmanifest.txt
1549360440
conaninfo.txt: ef2964b8f3037c9fb22512f086cf59b7
include/zconf.h: 8e174685774bae412b6e4aa354057f96
include/zlib.h: 0338828e9d00c94645648b1517108324
lib/libz.a: 668bc4404de773e98b23f8ed770dca1f
licenses/LICENSE: 1af2e5353c16e930435fff550f827c3e
zlib.pc: 5e60c1b132813bdcd04706c03dcb8f99

Also, you could add a hook to run conan get after to package.

But maybe we could customize the number of files listed when packaging by an environment variable. WDYT @memsharded ?

related issue: #4479

Regards!

@sigiesec
Copy link
Contributor Author

sigiesec commented Mar 7, 2019

Hi @uilianries, thanks for the suggestion, however this is missing a critical information, namely which call of copy caused the particular files to be copied, i.e. in particular the values of the pattern and src parameters. This is particularly hard to debug if something is wrong.

@memsharded
Copy link
Member

Implemented in #15513 for next 2.1 release

@memsharded memsharded added this to the 2.1 milestone Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants