Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the CMake variables for cpp_info.frameworks #5909

Closed
danimtb opened this issue Oct 15, 2019 · 1 comment · Fixed by #6003
Closed

Complete the CMake variables for cpp_info.frameworks #5909

danimtb opened this issue Oct 15, 2019 · 1 comment · Fixed by #6003

Comments

@danimtb
Copy link
Member

danimtb commented Oct 15, 2019

While integrating new changes in #5582, I realized some general variables are missing for frameworks.

Currently, only the CONAN_FRAMEWORK_<framework> variable is generated, but there is no variable to iterate the global frameworks or the package's ones. These variables could be useful and should be added for completeness and consistency.

  • CONAN_FRAMEWORKS: GLobal variable with all the frameworks on the dependency graph.
  • CONAN_FRAMEWORKS_<PKG-NAME>: All frameworks of the package

Additionally, check the tests that are checking the CONAN_LIBS_<PKG-NAME>, as this variable should only contain the package libraries but not the frameworks one. For example: https://github.com/conan-io/conan/pull/5582/files#diff-b50c3899bc268f45979432c9903b5539R343

@lasote
Copy link
Contributor

lasote commented Oct 30, 2019

About why are we doing a previous find_library for frameworks: https://cmake.org/pipermail/cmake-developers/2017-August/030199.html
Summary:
CMake needs to know if "foundation" is a library or a framework, and the only way to achieve it is to do a find_library that will resolve to an absolute path that (later) cmake knows to recognize as a framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants