Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipes that are too big to fail #8

Open
CJ-Wright opened this issue Jul 17, 2018 · 8 comments
Open

recipes that are too big to fail #8

CJ-Wright opened this issue Jul 17, 2018 · 8 comments

Comments

@CJ-Wright
Copy link
Member

There are core recipes which are "too big to fail". These are recipes, if they are built incorrectly will cause systemic problems across the ecosystem. For example the recent move of some recipes to noarch could have caused problems with conda itself.

We need to have tighter control of these recipes.

I think that we need to (at least):

  1. Have all (or at least some) of core as maintainers of these packages
  2. Require review approval to merge
@ericdill
Copy link
Member

Can you start putting together a list whose goal is to provide exhaustive coverage of these too big to fail recipes?

@CJ-Wright
Copy link
Member Author

Sure, although some help on that front would be good since this can be subjective.

@CJ-Wright
Copy link
Member Author

I think we should also put this info in extra since this is a property of the feedstock best managed there.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 27, 2018

I would start with gdal, openvc, and qt.

@msarahan
Copy link
Member

I disagree with gdal and opencv. I'm on the fence about qt.

Don't get me wrong, those are important packages. I don't believe that they are systemic, though.

Python, conda's core deps, the key compression and image libraries (bzip2, zlib, jpeg, libpng, libtiff) are more what I think of for this topic.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 27, 2018

I used gdal as a guide b/c all of

bzip2, zlib, jpeg, libpng, libtiff

are its dependencies. If we can rebuild the stack up to gdal we get roughly 80% of the important packages.

@CJ-Wright
Copy link
Member Author

CJ-Wright commented Jul 30, 2018

Side note, can we have a core Jinja variable which lists the core developers and then add that to the maintainers for these packages? That way we don't need to explicitly add everyone and as the make-up of core changes these recipes change too. My biggest concern is how conda smithy knows who to add to the feedstock, does it render the recipe?

We'd most likely want to put this variable somewhere central.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 30, 2018

I like that idea but maybe we may want that to be a subset of the core (maybe volunteers only?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants