Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI breaks because of use of environ #93

Closed
pelson opened this issue Apr 15, 2016 · 13 comments · Fixed by #96 or #98
Closed

CI breaks because of use of environ #93

pelson opened this issue Apr 15, 2016 · 13 comments · Fixed by #96 or #98

Comments

@pelson
Copy link
Member

pelson commented Apr 15, 2016

https://travis-ci.org/conda-forge/conda-forge.github.io/jobs/123324519

Looks like the change to use environ in conda-forge/staged-recipes#358 broke the teams script.

@jakirkham
Copy link
Member

Is that the right PR?

@pelson
Copy link
Member Author

pelson commented Apr 15, 2016

@jakirkham
Copy link
Member

Sorry, I see what you mean. Why would that cause it to break though? Is it just because PY_VER is undefined? Could we just pick an arbitrary value and set it in advance?

@pelson
Copy link
Member Author

pelson commented Apr 15, 2016

The problem is https://github.com/conda-forge/conda-forge.github.io/blob/master/scripts/update_teams.py#L82.

The result isn't important, so we can just mock out what environment does in there I think.

@jakirkham
Copy link
Member

Are you awake or is that just more automation?

@jakirkham
Copy link
Member

Close, but not quite. Let's try again.

@jakirkham
Copy link
Member

Nearly there.

@jakirkham
Copy link
Member

Nope. There are too many fun tricks in this line.

@jakirkham
Copy link
Member

Maybe we solve this before hitting #100. 😜

@jakirkham
Copy link
Member

jakirkham commented Apr 16, 2016

🎉 Solved! 🎉

Happy to discuss with anyone how this went down.

@pelson
Copy link
Member Author

pelson commented Apr 16, 2016

Hmmm. No, I wasn't awake. Thanks for solving, but I'm going to have to dig into the reason for the automatic labelling... slightly concerned. (I have no idea why you were assigned either)

@pelson
Copy link
Member Author

pelson commented Apr 16, 2016

Hmmm. No, I wasn't awake. Thanks for solving, but I'm going to have to dig into the reason for the automatic labelling... slightly concerned. (I have no idea why you were assigned either)

I wonder if it was waffle.io. I've cut it off to see if that is the source of the automatic labelling.

@jakirkham
Copy link
Member

Hmmm. No, I wasn't awake.

I figured not. Was half joking.

Thanks for solving...

Sure. If you have other thoughts on it, feel free to let me know.

I'm going to have to dig into the reason for the automatic labelling...

Have also seen in progress labels in other places. Tried asking about it a couple weekends ago, but think everyone was busy.

I wonder if it was waffle.io. I've cut it off to see if that is the source of the automatic labelling.

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants