Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally make schema validation errors a warning instead of erroring out during rerenders #1879

Closed
beckermr opened this issue Mar 21, 2024 · 2 comments · Fixed by #1885
Closed

Comments

@beckermr
Copy link
Member

This feature is stopping the bot from making PRs on effected feedstocks. As @isuruf has pointed out, the linter will error on the CI checks anyways, so letting the rerender go through is fine.

At minimum, we can add an optional override to only warn.

@jakirkham
Copy link
Member

Yeah warning on re-rendering seems like a better default

Having an option to convert warnings to errors in conda-smithy could be useful, but maybe that is not needed given the linter already errors. If we do add such an option, it would be good to cover on CI (to catch any false positives early)

@jaimergp
Copy link
Member

Agreed on this strategy.

  • conda-smithy rerender will warn about validation errors. If they are critical, they'll fail later in the job anyway.
  • conda-smithy recipe-lint will error out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants