Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking old CuPy 13 packages (with activation scripts) broken #255

Open
jakirkham opened this issue Feb 8, 2024 · 5 comments
Open

Marking old CuPy 13 packages (with activation scripts) broken #255

jakirkham opened this issue Feb 8, 2024 · 5 comments

Comments

@jakirkham
Copy link
Member

After discussion in issue ( #206 ), we decided recently to drop the activation scripts from CuPy packages ( #252 ). This happened in CuPy 13 packages, but only started with build/number: 3. As this is a breaking change and it happened in a later build/number, some CuPy 13 packages have activation scripts and others do not. To make the user experience more consistent, it would be preferable for CuPy 13 packages that had activation scripts to be marked broken. This way the breaking change of removing activation scripts aligns to installing CuPy 13 (a major version that can contain other breaking change)

Note: This is a follow up to comment ( #206 (comment) ) and offline discussion with @leofang and @mtjrider where we thought this would be a reasonable change

@jakirkham
Copy link
Member Author

If this is reasonable, the next steps would be:

@leofang
Copy link
Member

leofang commented Apr 8, 2024

@mtjrider is this something you can help with?

@mtjrider
Copy link

mtjrider commented Apr 8, 2024

Yup. It's in my backlog for today.

I'll comment again later today.

@mtjrider
Copy link

mtjrider commented Apr 9, 2024

Yup. It's in my backlog for today.

I'll comment again later today.

Checking in.
I'm wrapping up a few other actions today and can get this knocked out in the afternoon.

@jakirkham
Copy link
Member Author

@mtjrider did you put something together? Do you need a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants