Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: add a few more tests to the conda test section in meta #11

Open
1 task done
shimwell opened this issue Feb 20, 2022 · 2 comments
Open
1 task done

Comments

@shimwell
Copy link
Contributor

The meta.yml file supports testing of the conda package.

I was thinking we could add a test that checks that the conda package can be compiled with the develop branch of openmc or the main branch of openmc.

This is somewhat along the same lines as the discussion here. svalinn/DAGMC#795

Such a test would help avoid issues like this one reoccurring

@gonuke
Copy link
Contributor

gonuke commented Feb 20, 2022

It is probably not appropriate to test that we can compile DAGMC with any specific single downstream code. Rather, we can create an integration test that has minimal size and mimics the process of compiling with a downstream code.

@gonuke
Copy link
Contributor

gonuke commented Feb 20, 2022

Those tests should be part of the DAGMC test suite and tested there, and then just invoked here as well. In fact, we should probably be running existing DAGMC tests here already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants