Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows compilers #43

Closed
h-vetinari opened this issue Feb 4, 2024 · 2 comments
Closed

Update windows compilers #43

h-vetinari opened this issue Feb 4, 2024 · 2 comments

Comments

@h-vetinari
Copy link
Member

Hey all

This feedstock is still using VS2017 as the compiler on windows

c_compiler: # [win]
- vs2017 # [win]
- vs2017 # [win]
- vs2017 # [win]
cxx_compiler: # [win]
- vs2017 # [win]
- vs2017 # [win]
- vs2017 # [win]

apparently unchanged since the introduction of windows support; in the meantime, conda-forge has moved on to vs2019 as the default compiler a while ago already.

If you think you need vs2017, please let us know why (generally vs2019 and vs2022 should be fully compatible), otherwise please just remove those pins and rely on the defaults (in this case, conda_build_config.yaml could be removed in its entirety).

@rcurtin
Copy link
Contributor

rcurtin commented Feb 9, 2024

Thanks, I have no idea why those versions in particular are specified. I tried removing them in #44; I'll work to get that merged and then this will be resolved. 👍

@rcurtin rcurtin mentioned this issue Feb 9, 2024
5 tasks
@rcurtin
Copy link
Contributor

rcurtin commented Feb 9, 2024

Ok, merged an updated build. I think this is fixed; @h-vetinari let me know if anything else needs to be done. 👍

@rcurtin rcurtin closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants