Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows compilers #44

Closed
h-vetinari opened this issue Feb 4, 2024 · 2 comments · Fixed by #45
Closed

Update windows compilers #44

h-vetinari opened this issue Feb 4, 2024 · 2 comments · Fixed by #45
Assignees

Comments

@h-vetinari
Copy link
Member

Hey all

This feedstock is directly specifying vs2017_win-64 as a dependency,

requirements:
build:
- python # [build_platform != target_platform]
- cross-python_{{ target_platform }} # [build_platform != target_platform]
- numpy # [build_platform != target_platform]
- {{ compiler('cxx') }} # [not win]
- vs2017_win-64 # [win64]
- vs2017_win-32 # [win32]

but should just rely on the {{ compiler('c') }} function to provide the correct compilers on windows. In particular, conda-forge has moved on to vs2019 as the default compiler a while ago already, and doesn't support 32-bit builds anymore.

If you think you need vs2017, please let us know why (generally vs2019 and vs2022 should be fully compatible). If it's really necessary, please use the dedicated mechanism in conda_build_config.yaml for that, i.e.

c_compiler:     # [win]
  - vs2017      # [win]
cxx_compiler:   # [win]
  - vs2017      # [win]

as opposed to specifying it in meta.yaml directly

@jcarpent
Copy link
Contributor

jcarpent commented Feb 9, 2024

This is not needed at all. We can drop it indeed.

@jcarpent
Copy link
Contributor

jcarpent commented Feb 9, 2024

@jorisv Could you handle this?

@jorisv jorisv self-assigned this Feb 9, 2024
@jorisv jorisv mentioned this issue Feb 9, 2024
5 tasks
@jorisv jorisv linked a pull request Feb 9, 2024 that will close this issue
5 tasks
@jorisv jorisv closed this as completed in #45 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants