Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recipe #38

Closed
mfansler opened this issue Oct 28, 2024 · 10 comments · Fixed by #40
Closed

Update recipe #38

mfansler opened this issue Oct 28, 2024 · 10 comments · Fixed by #40

Comments

@mfansler
Copy link
Member

This is a placeholder/reminder to have a look at this recipe, re: conda-forge/staged-recipes#27507.

Please ping me if I don't check back in on this within a week.

@arturdaraujo
Copy link
Contributor

I used grayskull to create the recipe but I don't see any changes. I'm not sure if this PR is in the correct place.

arturdaraujo/staged-recipes@eb10730

@arturdaraujo
Copy link
Contributor

arturdaraujo commented Oct 28, 2024

I think I got it now. I updated the recipe directly in featurewiz-feedstock.
ae6601f

@marcelotrevisani
Copy link
Member

it should be fixed with #39

@arturdaraujo
Copy link
Contributor

Just merged! Thank you guys so much!

@mfansler
Copy link
Member Author

mfansler commented Oct 28, 2024

I think I got it now. I updated the recipe directly in featurewiz-feedstock. ae6601f

Please review the Maintainer documentation: https://conda-forge.org/docs/maintainer/updating_pkgs/#forking-and-pull-requests

Users should never push to main or to anything in the feedstock directly. Instead, you are expected to use a personal fork, use a branch on that fork, then submit that as a PR to the feedstock.

Just merged! Thank you guys so much!

As mentioned elsewhere (conda-forge/status#188) there is a widespread outage of PR build jobs. The PR did not actually run any checks to see that the suggested updates were working. Turns out they weren't. I would ask that you please wait until that situation is resolved.

@mfansler
Copy link
Member Author

This first needs conda-forge/lazytransform-feedstock#19.

@arturdaraujo
Copy link
Contributor

Is there anything that I can do on my end now that lazytransform is updated?

@mfansler
Copy link
Member Author

mfansler commented Nov 5, 2024

@arturdaraujo as a first attempt, there should be a "Re-run" button/link that you can click on the previous failed build attempt: https://github.com/conda-forge/featurewiz-feedstock/runs/32164285178

@mfansler
Copy link
Member Author

mfansler commented Nov 5, 2024

If that doesn't work, then we might need a new PR to make further adjustments.

@arturdaraujo
Copy link
Contributor

arturdaraujo commented Nov 5, 2024

It failed
Image

@mfansler mfansler mentioned this issue Nov 6, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants