Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run full test suite? #66

Open
jhale opened this issue Feb 7, 2024 · 1 comment · May be fixed by #67
Open

Run full test suite? #66

jhale opened this issue Feb 7, 2024 · 1 comment · May be fixed by #67
Labels
question Further information is requested

Comments

@jhale
Copy link

jhale commented Feb 7, 2024

Comment:

The tests at https://github.com/conda-forge/fenics-dolfinx-feedstock/blob/main/recipe/test-dolfinx.sh look very basic. Would it be possible to execute the entire Python test suite on 1 and 2 MPI ranks?

@jhale jhale added the question Further information is requested label Feb 7, 2024
@minrk
Copy link
Member

minrk commented Mar 18, 2024

cppimport isn't packaged yet, so can't run every test yet (have to add --ignore unit/fem/test_assemble_cppimport.py --ignore unit/common/test_mpi.py --ignore unit/la/test_casters.py).

I'd also like to avoid running the bulk of actual unittests that don't exercise interactions with dependencies, since those aren't relevant for packaging, and failures aren't actionable here. So if you can point me to either a subset of tests that exercise the build and/or a subset of tests that that are most expensive and don't actually exercise interactions with dependencies so they can be safely excluded (looks like unit/fem/test_dof_permuting.py and unit/fem/test_element_integrals.py might be a start, is that accurate?)

@minrk minrk linked a pull request Mar 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants