Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows compilers #65

Closed
h-vetinari opened this issue Feb 4, 2024 · 4 comments · Fixed by #66
Closed

Update windows compilers #65

h-vetinari opened this issue Feb 4, 2024 · 4 comments · Fixed by #66

Comments

@h-vetinari
Copy link
Member

Hey all

This feedstock is directly specifying vs2017_{{ target_platform }} as a dependency,

requirements:
build:
- libtool # [unix]
- {{ compiler('c') }}
- {{ compiler('cxx') }}
- vs2017_{{ target_platform }} # [win]

but should just rely on the {{ compiler('c') }} function to provide the correct compilers on windows. In particular, conda-forge has moved on to vs2019 as the default compiler a while ago already.

If you think you need vs2017, please let us know why (generally vs2019 and vs2022 should be fully compatible). If it's really necessary, please use the dedicated mechanism in conda_build_config.yaml for that, i.e.

c_compiler:     # [win]
  - vs2017      # [win]
cxx_compiler:   # [win]
  - vs2017      # [win]

as opposed to specifying it in meta.yaml directly

@vtraag
Copy link
Contributor

vtraag commented Feb 4, 2024

Re-opened because of need to re-render: #64 (comment)

@h-vetinari
Copy link
Member Author

Thanks for the quick response!

You can see that it's already rerendered correctly if you look into the generated ci configuration:

c_compiler:
- vs2019

@xylar
Copy link
Contributor

xylar commented Feb 4, 2024

Ah, great! That saves us some trouble!

@h-vetinari
Copy link
Member Author

This is still used in the test requirements:

- vs2017_{{ target_platform }} # [win]

@h-vetinari h-vetinari reopened this Feb 12, 2024
@xylar xylar mentioned this issue Feb 12, 2024
4 tasks
@xylar xylar closed this as completed in #66 Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants