spdlog leaks into librmm (?)

[leofang]

Not sure if this is intended --- I downloaded the librmm package and inspected the files locally, and this is what I saw:

There are headers and also a static library for spdlog, but should these be included in the librmm package? I thought spdlog is a standalone package?

librmm-feedstock/recipe/meta.yaml

Line 27 in 32b6251

- spdlog =1.7.0

My guess is these are due to spdlog being fetched by cmake instead of conda.

cc: @kkraus14 @jakirkham @rlratzel

[kkraus14]

Yep, need it in the host section instead of just the run section

[isuruf]

lib64 needs to be changed to lib

[leofang]

Yep, need it in the host section instead of just the run section

It has run_exports so I think we just need the host section
https://github.com/conda-forge/spdlog-feedstock/blob/c96430f1cb8e576908e2cd295e9bf73a4a245d57/recipe/meta.yaml#L15-L16

[leofang]

@kkraus14 What exactly does the build script do? Why isn't it generating a librmm.so shared library?

[leofang]

(I mean I know it's a header-only library, so an equivalent question is why do we need a cmake build script for rmm? We didn't need one for Thrust/CUB.)

[kkraus14]

I don't quite remember if the CMake install process generates the correct CMake pieces to allow someone to do a find_package(RMM)

[leofang]

OK. There are rmm-*.cmake included in the package, so I think this is why.

[jakirkham]

Think we need it in both host and run since it is also needed by libraries including RMM

[leofang]

Yes, @jakirkham, I just pushed #3.

[jakirkham]

Thanks Leo! 😄

Proposing we mark the old packages broken in PR ( conda-forge/admin-requests#259 ). So that users don't get these by accident