Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for feedstock use of compiler-bindir as well as -ccbin #98

Open
1 task done
mabraham opened this issue Jun 8, 2023 · 2 comments
Open
1 task done

Check for feedstock use of compiler-bindir as well as -ccbin #98

mabraham opened this issue Jun 8, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@mabraham
Copy link

mabraham commented Jun 8, 2023

Solution to issue cannot be found in the documentation.

  • I checked the documentation.

Issue

recipe/linux/nvcc.sh tries to avoid adding a second -ccbin argument to nvcc, but it does not check for the use of --compiler-bindir. The latter synonym was introduced in recent years.

I think nvcc.sh should check for both, per https://docs.nvidia.com/cuda/cuda-compiler-driver-nvcc/index.html#compiler-bindir-directory-ccbin

This is currently causing issues with the gromacs-feedstock at conda-forge/gromacs-feedstock#17, whose CMake tries to check nvcc for compatible flags and experiences warnings about the use of multiple such flags.

Installed packages

not applicable

Environment info

not applicable
@mabraham mabraham added the bug Something isn't working label Jun 8, 2023
@mabraham
Copy link
Author

mabraham commented Jun 8, 2023

@jakirkham
Copy link
Member

There is this line that could be tweaked somehow

case ${arg} in -ccbin)

Though note nvcc is used on CUDA 11. It is a wrapper script that calls an existing nvcc (in conda-forge the nvcc binary comes from the Docker image)

The CUDA 12 compiler package is in the cuda-nvcc feedstock. It currently lacks this logic for either flag. So it looks like we need to add this there. Have filed issue ( conda-forge/cuda-nvcc-feedstock#20 ) as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants