-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package build string harmonization with tensorflow and pytorch #83
Comments
The initial choice for the build string currently used is detailed in #63 (comment) . In a nutshell, I tried to take inspiration from existing packages, but personally I do not have any strong opinion on this. |
Ok, looking a bit it seems that I copied the one used in libarrow: https://github.com/conda-forge/arrow-cpp-feedstock/blob/cb3550db9a03b0a24d71427dcf0a21939d74fe15/recipe/meta.yaml#L112C19-L112C27 / pyarrow: https://github.com/conda-forge/arrow-cpp-feedstock/blob/cb3550db9a03b0a24d71427dcf0a21939d74fe15/recipe/meta.yaml#L624 , for me it is fine to change. |
Comment:
Would it acceptable to harmonize the build string with that of tensorflow and pytorch
onnxruntime (this feedstock)
The main features that are missing:
cuda
comes at the end, whereas it arrives at the beginning in tensorflow and pytorchTensorflow:
https://github.com/conda-forge/tensorflow-feedstock/blob/main/recipe/meta.yaml#L136
Pytorch
https://github.com/conda-forge/pytorch-cpu-feedstock/blob/main/recipe/meta.yaml
The text was updated successfully, but these errors were encountered: