Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package build string harmonization with tensorflow and pytorch #83

Open
hmaarrfk opened this issue Nov 12, 2023 · 2 comments
Open

Package build string harmonization with tensorflow and pytorch #83

hmaarrfk opened this issue Nov 12, 2023 · 2 comments
Labels
question Further information is requested

Comments

@hmaarrfk
Copy link
Contributor

Comment:

Would it acceptable to harmonize the build string with that of tensorflow and pytorch

onnxruntime (this feedstock)

{% set build_ext = "cuda" if cuda_enabled else "cpu" %}
  string: py{{ CONDA_PY }}h{{ PKG_HASH }}_{{ PKG_BUILDNUM }}_{{ build_ext }}

The main features that are missing:

  1. The version of cuda that things are compiled with is not immediately obvious.
  2. cuda comes at the end, whereas it arrives at the beginning in tensorflow and pytorch

Tensorflow:
https://github.com/conda-forge/tensorflow-feedstock/blob/main/recipe/meta.yaml#L136


      string: cuda{{ cuda_compiler_version | replace('.', '') }}py{{ CONDA_PY }}h{{ PKG_HASH }}_{{ PKG_BUILDNUM }}  # [cuda_compiler_version != "None"]
      string: cpu_py{{ CONDA_PY }}h{{ PKG_HASH }}_{{ PKG_BUILDNUM }}                                                # [cuda_compiler_version == "None"]

Pytorch
https://github.com/conda-forge/pytorch-cpu-feedstock/blob/main/recipe/meta.yaml

      string: cuda{{ cuda_compiler_version | replace('.', '') }}py{{ CONDA_PY }}h{{ PKG_HASH }}_{{ PKG_BUILDNUM }}  # [cuda_compiler_version != "None"]
      string: cpu_{{ blas_impl }}_py{{ CONDA_PY }}h{{ PKG_HASH }}_{{ PKG_BUILDNUM }}                                                # [cuda_compiler_version == "None"]
@hmaarrfk hmaarrfk added the question Further information is requested label Nov 12, 2023
@traversaro
Copy link
Contributor

The initial choice for the build string currently used is detailed in #63 (comment) . In a nutshell, I tried to take inspiration from existing packages, but personally I do not have any strong opinion on this.

@traversaro
Copy link
Contributor

The initial choice for the build string currently used is detailed in #63 (comment) . In a nutshell, I tried to take inspiration from existing packages, but personally I do not have any strong opinion on this.

Ok, looking a bit it seems that I copied the one used in libarrow: https://github.com/conda-forge/arrow-cpp-feedstock/blob/cb3550db9a03b0a24d71427dcf0a21939d74fe15/recipe/meta.yaml#L112C19-L112C27 / pyarrow: https://github.com/conda-forge/arrow-cpp-feedstock/blob/cb3550db9a03b0a24d71427dcf0a21939d74fe15/recipe/meta.yaml#L624 , for me it is fine to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants