Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track_features openjdk #37

Closed
jakirkham opened this issue Nov 22, 2018 · 4 comments
Closed

track_features openjdk #37

jakirkham opened this issue Nov 22, 2018 · 4 comments

Comments

@jakirkham
Copy link
Member

Appears this is using track_features. Why is that? Also should it be using track_features or something else to achieve that goal?

track_features:
- openjdk

@sodre
Copy link
Member

sodre commented Nov 22, 2018

I think this was so we could use different JDK implementations.

@jakirkham
Copy link
Member Author

Makes sense. Thanks for the info.

In that case it seems like the general trend is to use a mutex package for this kind of problem. They are a bit better behaved, but they are a relatively new concept (built on existing conda/conda-build functionality). Some good discussion about this in issue ( conda-forge/clangdev-feedstock#40 ).

@sodre
Copy link
Member

sodre commented Nov 22, 2018

Okay, in that case I will remove the track-features set if it is okay with you.

@jakirkham
Copy link
Member Author

Sounds good.

To clarify a bit, the mutex package uses track_features to indicate all non-default builds of a package as it relies on Conda's desire to minimize features. For example we might have openjdk from different vendors (Zulu, IntelliJ, etc.). If we picked one vendor build as the preferred openjdk (e.g. IntelliJ), then we would add track_features to all of the non-default builds (e.g. Zulu, etc.). These would all live in the same feedstock and all be called openjdk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants