-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: The pandoc recipe has some lint :( #7
Comments
This script may be misbehaving 😉 |
Does the script use the |
BTW: would it be possible to build a webpage which has all the lints and explains why this is necessary? E.g. in this case it's missing the number, but I don't know why I should add it because usually at this state there will only be one package version for each pandoc version. |
No, it is cloning each of the feedstocks locally without that repo (I've generally avoided making that the canonical source of these scripts). All that is missing is that I'm not pulling any subsequent changes after they have been merged onto the upstream feedstock.
Sure. We could even start with a wiki in https://github.com/conda-forge/conda-smithy if you like. Of course, there are always issue comments and gitter to get feedback on specific cases. |
Could be compiled into these docs ( conda-forge/conda-forge.github.io#95 ). |
@jakirkham That doc looks nice, that's enough for me here (although it also does not explain why its better to include a build number :-) ). |
Yeah, we should start having some sort of PEP system or probably something way less formal for linter proposals. In any event, I think the rationale is this just makes life simpler. We tell people to set this number back to 0 on updating in the Readme. Keeping it always makes that compliant with the instructions. Also, some people are entering conda-forge that know nothing about |
Pandoc no longer has any lint. 👍 |
This is the friendly conda-forge-admin automated user.
I've ran the conda-smithy linter and found some lint in this feedstock 😢.
Here is what I have got:
build/number
section.Thanks!
The text was updated successfully, but these errors were encountered: