Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

globally pin the pybind11 versions #53

Closed
beckermr opened this issue Oct 9, 2020 · 2 comments · Fixed by #63
Closed

globally pin the pybind11 versions #53

beckermr opened this issue Oct 9, 2020 · 2 comments · Fixed by #63

Comments

@beckermr
Copy link
Member

beckermr commented Oct 9, 2020

Issue:


Environment (conda list):
$ conda list


Details about conda and system ( conda info ):
$ conda info

We got a report from @bluescarni (see conda-forge/conda-forge-pinning-feedstock#849 (comment)) that different pybind11 versions generate python libraries which are not interoperable between one another.

Assuming this is, in fact, true, we plan to globally pin the version of pybind11 for all of conda-forge. See conda-forge/conda-forge-pinning-feedstock#849. This will ease the maintenance burden for users who want to use different packages together and don't want to run around updating pins in recipes.

cc @conda-forge/core @conda-forge/pybind11

@henryiii
Copy link
Contributor

This should only change when the internal ABI string changes. The string last changed for 2.4, I believe. Also, keep in mind that many (most?) packages internally pin pybind11, by submodule (in git) and including the headers in the SDist.

@beckermr
Copy link
Member Author

This should only change when the internal ABI string changes.

What are you referring to? The pin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants