Force Siphash hashing #733
Conversation
When cross-compiling, the hash function is forced to be FNV because the configure script defines `HAVE_ALIGNED_REQUIRED` which is then used by pyhash.h to change the default to FNV (see conda-forge#718) This commit fixes the issue by specifying siphash24 to the configure script when cross-compiling.
|
@conda-forge-admin, please rerender |
recipe/build_base.sh
Outdated
| # Force siphash24 (https://github.com/conda-forge/python-feedstock/issues/718): | ||
| _common_configure_args+=(--with-hash-algorithm=siphash24) | ||
|
|
There was a problem hiding this comment.
Let's remove this so that if upstream changes the default algorithm, we won't fall behind.
There was a problem hiding this comment.
Removed in 8b77bac
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.10.15.14.11.30
| echo "ac_cv_aligned_required=no" >> config.site | ||
| if [[ "${target_platform}" == "osx-arm64" || "${target_platform}" == "linux-ppc64le" || "${target_platform}" == "linux-aarch64" ]]; then | ||
| echo "ac_cv_aligned_required=no" >> config.site |
There was a problem hiding this comment.
This doesn't change anything right?
There was a problem hiding this comment.
Right, it is just trying to replicate a similar change in #719, which I think ended up adding ac_cv_aligned_required=no twice to config.site.
There was a problem hiding this comment.
If you prefer, I can remove this change.
matthiasdiener
requested review from
chrisburr,
jakirkham,
katietz,
mbargull,
msarahan,
ocefpaf,
pelson,
scopatz and
xhochy
as code owners
|
Closing in favor of #737. |
Continuation of #719. Closes #718.
See also #432.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)