Compile sysconfig's data
#742
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nda-forge-pinning 2024.11.13.19.27.51
It appears `sysconfig`'s data doesn't get compiled until install time, which results in a file modification after installation. This can throw up red flags in certain install environments and when using `conda doctor`. To address this, `import sysconfig` and run `sysconfig.get_config_vars()`, which loads the data file as a `dict`. This should compile the data file. Also `pprint` the data for additional debug information/validation.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
jakirkham
commented
Nov 14, 2024
| python -c "import compileall,os;compileall.compile_dir(os.environ['PREFIX'])" | ||
| python -c "import pprint, sysconfig; pprint(sysconfig.get_config_vars())" |
There was a problem hiding this comment.
As there is a fair bit of logic above to handle the generation of sysconfig data (and possibly additional considerations for cross-compilation), there may be a better approach than this. Open to suggestions
jakirkham
commented
Nov 14, 2024
Comment on lines
+188
to
+190
| :: Ensure `sysconfig`'s data is also compiled | ||
| %PREFIX%\python.exe -c "import pprint, sysconfig; pprint(sysconfig.get_config_vars())" | ||
| if %errorlevel% neq 1 exit /b 1 |
There was a problem hiding this comment.
Windows doesn't seem to have the same complexities as the UNIX builds. So think this is probably sufficient here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears
sysconfig's data doesn't get compiled until install time, which results in a file modification after installation. This can throw up red flags in certain install environments and when usingconda doctor. To address this,import sysconfigand runsysconfig.get_config_vars(), which loads the data file as adict. This should compile the data file.Also
pprintthe data for additional debug information/validation.Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Fixes #741