-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pytype package is broken due to missing python ninja package. #97
Comments
The lot thickens -- this may not be a pytype recipe bug, but a ninja package bug -- it doesn't seem to provide a working ninja command -- is pytype reverting to the python package due to that failure?
bug reported to the ninja feedstock: |
This is an upstream pytype regression in google/pytype#642, and commit google/pytype@1a6d0b3 should be partially reverted to run |
Thanks -- I took a look at the pytype code, and it's pretty buried. Not sure what to do here -- yes,it's a pytype bug, but the fact is we have a feedstock that produces a package that doesn't work :-( Maybe we should mark this version as broken (I think you can do that on anaconda.org), and not make a new one until pytype fixes its bug. I"ve been trying to see how far back I have to go to get a working pytype, and no luck yet. |
I couldn't find an issue in the pytype project, so I added one here: NOTE: I doubt they are going to revert that commit -- it was put in to solve a problem, but It also could be fixed, though all that code is a bit of a tangled mess, so I haven't figured out a PR :-( |
I've been going back to older versions of the conda pytype package -- well before the refrences commit -- and I haven't yet found one that works :-( It seems the pytype folks have been committed to the python-wrapped ninja for quite some time :-( I've gone back to 2022.01.05 -- didn't work then. :-( |
We could patch this here ourselves. I will give this a try |
see #98 |
Solution to issue cannot be found in the documentation.
Issue
The conda-forge package is broken (and unfixable :-( In short, it needs the python ninja package, but that package does not exist (yet) for conda-forge. There is a PR to add one, but it seems to be stalled out:
conda-forge/staged-recipes#19098
I'm not sure what the short term solution should be -- maybe pytype could vendor python-ninja? Or at least document that you need to pip-install the python ninja package to use it :-(
(and this issue might be that documentation for the moment)
But in any case, it's a bad idea to have a broken package in conda-forge :-(
Details:
create a new environment, with only pytype:
Try to use it:
The conda package
ninja
is there:But that's not the Python module, hence it doesn't work.
If you pip install the python ninja package, all is fine:
All good.
Installed packages
Environment info
The text was updated successfully, but these errors were encountered: