Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Hover link color in dark mode has insufficient contrast #2

Closed
jaimergp opened this issue Nov 10, 2023 · 4 comments
Closed
Assignees

Comments

@jaimergp
Copy link
Member

What happened?

This theme redefines carefully chosen defaults in the color palette to account for accessibility issues like contrast. The colors chosen are on brand with the conda ecosystem, and that's great, but there are some nuances that need to be taken into account to keep the accessibility features of the original theme.

For example, hover links color in dark mode is tricky to see:

image image image

This can be further assessed with the Chrome dev tools. Those horizontal curves in the color map are the minimum thresholds for AA and AAA; above means passing it, below means insufficient contrast.

image

Conda Info

N/A

Conda Config

N/A

Conda list

N/A

Additional Context

No response

@jaimergp
Copy link
Member Author

@jaimergp
Copy link
Member Author

Or this issue: pydata/pydata-sphinx-theme#1052

@travishathaway
Copy link
Contributor

Thanks for finding this. I don't use dark theme ever, which is why I missed it. Should be easy enough to fix.

@travishathaway travishathaway self-assigned this Nov 10, 2023
@travishathaway
Copy link
Contributor

This commit should address these issues:

I've made sure to use the same colors we defined in our style guide over here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants