Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate to conda organization #352

Open
jezdez opened this issue May 10, 2024 · 6 comments
Open

Graduate to conda organization #352

jezdez opened this issue May 10, 2024 · 6 comments

Comments

@jezdez
Copy link
Member

jezdez commented May 10, 2024

@conda-incubator/setup-miniconda

I'd like to propose graduating setup-miniconda to the main conda organization and merging the @conda-incubator/setup-miniconda team with the fledgling installer team, that I started in conda-incubator/installer#1, to bolster our ability to maintain it. I believe that would put a little energy into this effort and distribute the maintenance burden a bunch.

Also, since setup-miniconda supports multiple and custom installers (not just miniconda, despite its name), I would suggest renaming the repo to conda/setup-action as part of this process. Especially since GitHub doesn't ship a miniconda installation by default in the newest worker images anymore, it's worth making sure this is well-maintained.

The difference to the also existing @conda-incubator/constructor is that the installer and setup-miniconda teams are both downstream users of the constructor technology.

@chenghlee
Copy link

I'm on board with this graduation. (Though I suggest conda/setup-gh-action as a slightly less ambiguous name.)

@kenodegard
Copy link
Contributor

The name here mirrors that of other setup actions in the GHA ecosystem, (e.g., actions/setup-python, actions/setup-node, actions/setup-java). I see swift uses gha-setup-swift so that's an alternative pattern to consider.

@mattwthompson
Copy link

+1 for the name of the action indicating what it's setting up, i.e. continuing to mirror the ~replacement @mamba-org/setup-micromamba

@marcoesters
Copy link
Contributor

I would also be in favor of naming it conda/setup-conda as suggested by the pattern @kenodegard mentions.

The only thing to consider here is that we would lose all issues for the new repository since "graduating" here would probably mean creating a new repository instead of transferring. The way I read the GitHub documentation, transferring and renaming would break existing workflows that point to conda-incubator/setup-miniconda.

From the Transferring a repository documentation.

You can also change the repository name while transferring a repository. For more information, see "Renaming a repository."

And further from the Renaming a repository documentation.

Note: GitHub will not redirect calls to an action hosted by a renamed repository. Any workflow that uses that action will fail with the error repository not found. Instead, create a new repository and action with the new name and archive the old repository. For more information, see "Archiving repositories."

@jezdez
Copy link
Member Author

jezdez commented May 10, 2024

@marcoesters FWIW I'm aware of this limitation on GitHub's side, this ticket is about whether we want to do this step in the first place, per the conda governance policy about incorporating a project into the main conda community organization, less about how it's implemented.

@goanpeca
Copy link
Member

goanpeca commented May 24, 2024

My original intention for the name was for it to be setup-conda, but an action was already created with that name -> https://github.com/s-weigand/setup-conda, hence why the name is setup-miniconda

See: https://github.com/marketplace/actions/setup-conda

So the repo can be whatever we decide. conda/setup-conda works. The action name must be unique... and setup-conda is taken.

So I am not even sure if the name change is possible. Since this would be a more "official" conda action, we could ask s-weigand/setup-conda to join forces 🤷🏼

And 👍🏼 on graduating :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants