feature names with '-' is bugged

[dfroger]

If a feature is named for example python-debug, building the recipes fails with:

  File "/home/vagrant/miniconda3/bin/conda-build", line 6, in <module>
    sys.exit(conda_build.cli.main_build.main())
  File "/home/vagrant/miniconda3/lib/python3.5/site-packages/conda_build/cli/main_build.py", line 247, in main
    execute(sys.argv[1:])
  File "/home/vagrant/miniconda3/lib/python3.5/site-packages/conda_build/cli/main_build.py", line 239, in execute
    already_built=None, config=config, noverify=args.no_verify)
  File "/home/vagrant/miniconda3/lib/python3.5/site-packages/conda_build/api.py", line 77, in build
    need_source_download=need_source_download, config=config)
  File "/home/vagrant/miniconda3/lib/python3.5/site-packages/conda_build/build.py", line 1088, in build_tree
    config=recipe_config)
  File "/home/vagrant/miniconda3/lib/python3.5/site-packages/conda_build/build.py", line 817, in build
    tarcheck.check_all(tmp_path)
  File "/home/vagrant/miniconda3/lib/python3.5/site-packages/conda_build/tarcheck.py", line 91, in check_all
    x.index_json()
  File "/home/vagrant/miniconda3/lib/python3.5/site-packages/conda_build/tarcheck.py", line 62, in index_json
    getattr(self, varname)))
Exception: name: 'python' != 'python-3.5.2'

In tarcheck.py, if dist = python-3.5.2-python-debug_3, we get name, version, build = 'python-3.5.2', 'python', 'debug_3', which is wrong.

If dist = python-3.5.2-python_debug_3, we get name, version, build = 'python', '3.5.2', 'python_debug_3, which is correct.

[msarahan]

unfortunately, there is a ton of legacy logic that assumes a particular number of - characters, split from the right backwards. Changing conda-build to allow dashes in features is asking for a lot of trouble.

Instead, I'd propose to raise error messages when features with - are defined. Is that an acceptable solution to you?

[dfroger]

Hi, absolutely, I think raising a error message would be perfect! Thanks @msarahan

[github-actions]

Hi there, thank you for your contribution!

This issue has been automatically locked because it has not had recent activity after being closed.

Please open a new issue if needed.

Thanks!