Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONDA_BUILD_STATE not always set correctly #3116

Closed
bryevdv opened this issue Sep 6, 2018 · 1 comment · Fixed by #3117
Closed

CONDA_BUILD_STATE not always set correctly #3116

bryevdv opened this issue Sep 6, 2018 · 1 comment · Fixed by #3117
Labels
locked [bot] locked due to inactivity

Comments

@bryevdv
Copy link

bryevdv commented Sep 6, 2018

Attempting to update Bokeh TravisCI builds to conda-build 3.14 from 3.0.27 for bokeh/bokeh#8217 causes the Bokeh setup.py to ask for a build action interactively, stalling the build:

+conda build conda.recipe --quiet --no-test --no-anaconda-upload
Bokeh includes a JavaScript library (BokehJS) that has its own
build process. How would you like to handle BokehJS:
1) build and install fresh BokehJS
2) install last built BokehJS from bokeh/bokehjs/build
Choice? 

However, the interactive build prompt should be (and has been in previous versions) protected by a check for conda-build:

# if this is just conda-build skimming information, skip all this actual work
if not conda_rendering():
    fixup_for_packaged()   # --build_js and --install_js not valid FROM sdist
    fixup_building_sdist() # must build BokehJS when MAKING sdists

    bokehjs_action = build_or_install_bokehjs()

where conda_rendering is:

def conda_rendering():
    return os.getenv("CONDA_BUILD_STATE" ,"junk") == "RENDER"

@msarahan suggests:

seems like the load_setup_py_data may be operating in a different context somehow. The state variable stuff is tested at https://github.com/conda/conda-build/blob/master/tests/test-recipes/metadata/state_variables/meta.yaml, but that doesn't test it with loading setup.py data

@github-actions
Copy link

Hi there, thank you for your contribution!

This issue has been automatically locked because it has not had recent activity after being closed.

Please open a new issue if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant