Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: show rendered run dependencies #3798

Closed
minrk opened this issue Nov 5, 2019 · 7 comments · Fixed by #5344
Closed

Feature request: show rendered run dependencies #3798

minrk opened this issue Nov 5, 2019 · 7 comments · Fixed by #5344
Labels
locked [bot] locked due to inactivity stale::recovered [bot] recovered after being marked as stale stale [bot] marked as stale due to inactivity

Comments

@minrk
Copy link
Contributor

minrk commented Nov 5, 2019

This is a feature request for easier auditing/debugging, especially on CI.

I've made some mistakes over the years in packages that resulted in the wrong runtime dependencies, for example:

  • assuming deps use run_exports
  • unusual results from using the wrong one of pin_run_as_build or pin_subpackage
  • pinning build but not version overrides version pinning on conda_build_config (e.g. hdf5 * mpi_*)

These are all my mistakes (to varying degrees), but result in successfully built and tested packages that don't have the dependencies I expect or intend. Often these mistakes don't turn up until much later when a dependency package is updated. I'd have an easier time catching these if I could see the resulting dependencies of the recipe.

One simple version is to explicitly do conda render in conda-forge CI, but it might be nice to include some or all of this in conda-build output by default, particularly requirements.run and build.run_exports, which cannot currently be tested properly.

@msarahan
Copy link
Contributor

msarahan commented Nov 6, 2019

Sure, that seems like totally reasonable output after the rendering phase completes. A PR would be welcome, and otherwise we'll try to work it in.

@marcelotrevisani
Copy link
Member

I think that is nice indeed
Should we add an option like conda build . --verbose and it will show those extra info ?

@msarahan
Copy link
Contributor

msarahan commented Nov 6, 2019

I'd be fine with this being new default behavior, and having a flag to squelch it if so desired.

@minrk
Copy link
Contributor Author

minrk commented Nov 12, 2019

I'll definitely do this eventually if nobody else gets to it, but I'd love to be beaten to the punch since I'm currently half-time on parental leave and falling further behind every week.

@wolfv
Copy link
Contributor

wolfv commented Jul 14, 2020

we have something like this in boa now -- you can check the screencast in the readme. github.com/thesnakepit/boa

@github-actions
Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Mar 13, 2023
@github-actions github-actions bot added the stale::closed [bot] closed after being marked as stale label Apr 13, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 13, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Done in 🧭 Planning Apr 13, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
@jaimergp
Copy link
Contributor

Reopening for upcoming PR addressing this

@jaimergp jaimergp reopened this May 17, 2024
@github-project-automation github-project-automation bot moved this from 🏁 Done to 🏗️ In Progress in 🧭 Planning May 17, 2024
@conda conda unlocked this conversation May 17, 2024
@jaimergp jaimergp added stale::recovered [bot] recovered after being marked as stale and removed locked [bot] locked due to inactivity stale::closed [bot] closed after being marked as stale labels May 17, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to 🏁 Done in 🧭 Planning Jun 7, 2024
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Dec 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity stale::recovered [bot] recovered after being marked as stale stale [bot] marked as stale due to inactivity
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants