Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate noarch_python_build_age MetaData/Config setting #5297

Closed
2 tasks done
kenodegard opened this issue Apr 18, 2024 · 0 comments · Fixed by #5298
Closed
2 tasks done

Deprecate noarch_python_build_age MetaData/Config setting #5297

kenodegard opened this issue Apr 18, 2024 · 0 comments · Fixed by #5298
Assignees
Labels
in-progress issue is actively being worked on locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc. type::tech-debt identifies or resolves some technical debt
Milestone

Comments

@kenodegard
Copy link
Contributor

Checklist

  • I added a descriptive title
  • I searched open requests and couldn't find a duplicate

What is the idea?

Let's deprecate the unused noarch_python_build_age configuration value. It is not formally defined in either the old nor new recipe formats, isn't mentioned in our docs, and has no hits on GitHub or on Google.

It was introduced in 26dfe8e (in conda-build 3.21.0).

Why is this needed?

Remove tech-debt related to this block of code:

# don't bother distributing python if it's a noarch package, and figure out
# which python version we prefer. `python_age` can use used to tweak which
# python gets used here.
if metadata.noarch or metadata.noarch_python:
from .conda_interface import VersionOrder
age = int(
metadata.get_value(
"build/noarch_python_build_age", metadata.config.noarch_python_build_age
)
)
versions = []
for variant in variants:
if "python" in variant:
vo = variant["python"]
if vo not in versions:
versions.append(vo)
version_indices = sorted(
range(len(versions)), key=lambda k: VersionOrder(versions[k].split(" ")[0])
)
if age < 0:
age = 0
elif age > len(versions) - 1:
age = len(versions) - 1
build_ver = versions[version_indices[len(versions) - 1 - age]]
variants = filter_by_key_value(
variants, "python", build_ver, "noarch_python_reduction"
)

What should happen?

No response

Additional Context

No response

@kenodegard kenodegard added source::anaconda created by members of Anaconda, Inc. type::tech-debt identifies or resolves some technical debt in-progress issue is actively being worked on labels Apr 18, 2024
@kenodegard kenodegard self-assigned this Apr 18, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in 🧭 Planning Apr 18, 2024
@kenodegard kenodegard moved this from 🆕 New to 🏗️ In Progress in 🧭 Planning Apr 18, 2024
@beeankha beeankha added this to the 24.5.x milestone Apr 18, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to 🏁 Done in 🧭 Planning Apr 19, 2024
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Oct 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in-progress issue is actively being worked on locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc. type::tech-debt identifies or resolves some technical debt
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants