-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix run export substring check #5575
base: main
Are you sure you want to change the base?
Conversation
We require contributors to sign our Contributor License Agreement and we don't have one on file for @vyasr. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1088), and ping the bot to refresh the PR. |
I just signed the CLA. Let me know if I need to forward the confirmation email to anyone. |
One note that isn't directly related to this PR but did affect me is that the test requirements file is also missing a few additional requirements.
|
I also need a bit of help figuring out the right way to test this. I've verified the result manually, but I couldn't find an easy programmatic way of doing this with conda_build APIs since rendering isn't sufficient so we can't just inspect metadata. The best I could come up with is running the build and then manually extracting and inspecting the metadata of the result. I'm not sure if there is a better way, though. |
@@ -12,7 +12,7 @@ menuinst >=2 | |||
packaging | |||
pkginfo | |||
psutil | |||
py-lief | |||
py-lief <0.15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#5565 should make this unnecessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on when PRs get reviewed happy to remove this change or switch up the merge order as is convenient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise, I could merge or rebase on main and undo this inside #5565 if this gets merged first. Defer to maintainers on what order they'd rather merge in.
@conda-bot check |
CodSpeed Performance ReportMerging #5575 will not alter performanceComparing Summary
|
Description
This PR fixes #5529.
It also adds a constraint to the test requirements file that was previously missing but is required to get a compatible version of py-lief, and it updates the gitignore for vim swap files.
Checklist - did you ...
news
directory (using the template) for the next release's release notes?Add / update outdated documentation?