-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New cph extracts directory permissions differently #184
Comments
conda-package-handling 2.0 assumes Python tarfile would be acceptable, since conda used it until a few years ago (2018?) This tarfile subclass helps to control permissions https://github.com/conda/conda-package-streaming/blob/main/conda_package_streaming/package_streaming.py#L32 but it should only affect https://github.com/python/cpython/blob/3.11/Lib/tarfile.py#L2281 is the overridden method. We also added Do I see two shots of the new behavior in the screenshot? |
On my OSX laptop, umask is
|
hey, sorry for little explanation on the screenshots. the first one is the new one (on Linux) that shows that the permissions are extracted differently. I tested it in a Github Codespace. |
In Linux, in conda's own dockerfile container, I get permissions like
|
I see a number of vscode remote issues related to umask? Could this be related? |
Relevant libarchive flags for conda-package-handling 1.x series? https://github.com/conda/conda-package-handling/blob/1.9.0/src/conda_package_handling/archive_utils_c.c#L144 |
We updated conda-package-streaming (which conda-package-handling uses) to respect umask. Does conda/conda-package-streaming#65 fix this issue? |
Checklist
What happened?
The new conda package handling extracts directory permissions differently (sets writable bit) compared to how libarchive handled them.
The directories are actually implicitly created (on the fly).
Not sure if this is serious, but might be interesting to fix (also makes the directories appear "less weird" in the terminal :)
Here is a screenshot with the new cph on top, and using the
cph_test_data...
package from the this repo.Conda Info
No response
Conda Config
No response
Conda list
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: