Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend anaconda copy to allow name & version changes #11613

Closed
2 tasks done
msaroufim opened this issue Jul 9, 2022 · 2 comments
Closed
2 tasks done

Extend anaconda copy to allow name & version changes #11613

msaroufim opened this issue Jul 9, 2022 · 2 comments
Labels
locked [bot] locked due to inactivity type::feature request for a new feature or capability

Comments

@msaroufim
Copy link

msaroufim commented Jul 9, 2022

Checklist

  • I added a descriptive title
  • I searched open requests and couldn't find a duplicate

What is the idea?

I'd like to be able to download some conda binaries from https://anaconda.org/pytorch-nightly/torchserve-nightly and then promote them to https://anaconda.org/pytorch/torchserve. Version numbers for nightly scripts will include some date like 20220709 and the official release versions will look something like 0.6.0 https://docs.anaconda.com/anaconda-repository/user-guide/tasks/pkgs/copy-pkg/

So basically I'd like an extension of anaconda copy --old-name conda-forge/glueviz/20220101 --to jsmith/glueviz/0.23

But I'm not sure how to go about renaming a conda package even manually (would happily do so if an automated solution is ways out)

Why is this needed?

My team has a Github Action that takes care of uploading conda binaries for our package on a nightly basis pytorch/serve#1685

When that PR is landed we will be able to do official releases by using another manually triggerable Github Action which takes in as arguments a nightly release date to promote from and an official release version to promote to. The script will work by downloading a nightly release, renaming it and then reuploading to an official channel. This is somewhat easy to do with PyPi https://github.com/pytorch/serve/blob/master/binaries/pip/retag_pypi_binary.sh and especially easy with Docker with their docker tag

What should happen?

No response

Additional Context

No response

@msaroufim msaroufim added the type::feature request for a new feature or capability label Jul 9, 2022
@msaroufim msaroufim changed the title Extend anaconda copy to allow name changes Extend anaconda copy to allow name & version changes Jul 9, 2022
@msaroufim
Copy link
Author

msaroufim commented Jul 13, 2022

Hi folks did someone manage to take a look at this issue? I've settled on trying out something like this but it's not nearly as
clean as what I'm used to with the anaconda cli https://github.com/pytorch/serve/pull/1735/files#diff-9b4b87a31d6636dc6cc60083cca57156f0af4e881d72eb8d1f13d8c2c6db67de

But it unfortunately doesn't quite work

A repro

  1. wget https://anaconda.org/agunapal/torchserve/0.6.0.dev20220713/download/linux-64/torchserve-0.6.0.dev20220713-py39_0.tar.bz2
  2. wget https://raw.githubusercontent.com/pytorch/serve/c941363196c5cc8dd7d6ac6d7b68ea4604d65dff/binaries/conda/retag_conda_binary.sh
  3. NEW_VERSION=0.8.3 ./retag_conda_binary.sh torchserve-*
  4. anaconda upload torchserve*

Which fails and I probably need to spend more time figuring out what I'm doing wrong

(serve) ubuntu@ip-172-31-16-198:~/serve/binaries/conda$ anaconda upload torchserve-0.8.3-py39_0.tar.bz2 
Using Anaconda API: https://api.anaconda.org
Using "marksaroufim" as upload username
Processing 'torchserve-0.8.3-py39_0.tar.bz2'
Detecting file type...
[ERROR] Could not detect package type of file 'torchserve-0.8.3-py39_0.tar.bz2' please specify package type with option --package-type

@LtDan33
Copy link
Member

LtDan33 commented Jul 27, 2022

Hey @msaroufim thanks for the request! I'm not able to transfer this as it's a different org, so can you open this on the Anaconda Client repo? That is what the 'anaconda` command is and will put it in the right queue to be sorted through. Thanks!

@LtDan33 LtDan33 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 27, 2022
@LtDan33 LtDan33 moved this to Done in 🧭 Planning Jul 27, 2022
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jul 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity type::feature request for a new feature or capability
Projects
Archived in project
Development

No branches or pull requests

2 participants