-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installer filenames contain "MacOSX" instead of correct "macOS" #849
Comments
This is an easy fix but it might break a lot of automated CI because the download URL for e.g. Miniforge will change. We will need updates in setup-miniconda too. Users can still resort to the installer_filename: Miniconda-23.9.0-macOS-arm64.sh # [osx] |
What I am worried about here is that we currently do not know how many workflows will change. Other examples where these download links are used, homebrew, e.g. |
For setup-miniconda, there will be the additional complication that you can specify a version number, so older installers will have the MacOSX moniker. So, whatever changes will be made there will have to deal with that name change. |
Yes, we'll need to try both platform names til we find a valid download. |
Checklist
What happened?
Constructor seems to use an outdated name for the macOS platform that trickles down to the installers it builds.
We should start publishing our installers for “macOS” and not for “Mac OSX”, the latter hasn’t been accurate since 2016
Additional Context
No response
The text was updated successfully, but these errors were encountered: