Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer filenames contain "MacOSX" instead of correct "macOS" #849

Open
2 tasks done
jezdez opened this issue Sep 3, 2024 · 4 comments
Open
2 tasks done

Installer filenames contain "MacOSX" instead of correct "macOS" #849

jezdez opened this issue Sep 3, 2024 · 4 comments
Labels
severity::4 low; functionality is inconvenient source::anaconda created by members of Anaconda, Inc. type::bug describes erroneous operation, use severity::* to classify the type

Comments

@jezdez
Copy link
Member

jezdez commented Sep 3, 2024

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

Constructor seems to use an outdated name for the macOS platform that trickles down to the installers it builds.

We should start publishing our installers for “macOS” and not for “Mac OSX”, the latter hasn’t been accurate since 2016

Additional Context

No response

@jezdez jezdez added type::bug describes erroneous operation, use severity::* to classify the type source::anaconda created by members of Anaconda, Inc. severity::4 low; functionality is inconvenient labels Sep 3, 2024
@jaimergp
Copy link
Contributor

jaimergp commented Sep 13, 2024

This is an easy fix but it might break a lot of automated CI because the download URL for e.g. Miniforge will change. We will need updates in setup-miniconda too.

Users can still resort to the installer_filename option to change the name of the generated installers, btw. So something like this would work to opt-in early:

installer_filename: Miniconda-23.9.0-macOS-arm64.sh  # [osx]

@marcoesters
Copy link
Contributor

What I am worried about here is that we currently do not know how many workflows will change. Other examples where these download links are used, homebrew, e.g.

@marcoesters
Copy link
Contributor

For setup-miniconda, there will be the additional complication that you can specify a version number, so older installers will have the MacOSX moniker. So, whatever changes will be made there will have to deal with that name change.

@jaimergp
Copy link
Contributor

Yes, we'll need to try both platform names til we find a valid download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity::4 low; functionality is inconvenient source::anaconda created by members of Anaconda, Inc. type::bug describes erroneous operation, use severity::* to classify the type
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants