Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typed checksums #134

Closed
wolfv opened this issue Mar 27, 2023 · 3 comments · Fixed by #153
Closed

Typed checksums #134

wolfv opened this issue Mar 27, 2023 · 3 comments · Fixed by #153
Labels
enhancement New feature or request

Comments

@wolfv
Copy link
Contributor

wolfv commented Mar 27, 2023

Currently we're storing SHA256 and MD5 hashes as strings. I am wondering if it would be better to store them as typed byte arrays and de-/serialize them at the serde level only?
@baszalmstra baszalmstra added the enhancement New feature or request label Mar 28, 2023
@baszalmstra
Copy link
Collaborator

I like that a lot in different places in the codebase we now convert back and forth. rattler_digest should also already provide most of the things needed.

@wolfv
Copy link
Contributor Author

wolfv commented Mar 28, 2023

And it would be nice if we don't need to have sha2 and md5 crates outside of rattler digest (rather reexport them)

@baszalmstra
Copy link
Collaborator

baszalmstra commented Mar 30, 2023 •
edited
Loading

Partially done in:

Follow up issue:

@baszalmstra baszalmstra mentioned this issue Apr 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use digest in repodata baszalmstra/rattler
2 participants
@wolfv @baszalmstra