Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force docs on public functions and structs. #61

Closed
baszalmstra opened this issue Feb 20, 2023 · 4 comments · Fixed by #268
Closed

force docs on public functions and structs. #61

baszalmstra opened this issue Feb 20, 2023 · 4 comments · Fixed by #268

Comments

@baszalmstra
Copy link
Collaborator

All public methods in rattler crates should have proper docs. We can force this with #![warn(missing_docs)] or even #![deny(missing_docs)]. Some crates already have this but we need to play catchup for some of the others.

@baszalmstra
Copy link
Collaborator Author

baszalmstra commented Feb 20, 2023

Crates that still need to be fixed:

@wolfv
Copy link
Contributor

wolfv commented Mar 3, 2023

  • rattler_conda_types has been fixed! :)

@wolfv
Copy link
Contributor

wolfv commented Apr 11, 2023

I think the only two crates left are rattler and rattler_macros. Both are very much doable.

@wolfv
Copy link
Contributor

wolfv commented Jul 23, 2023

fixed by #268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants