Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PEP 639 license information to PypiPackageData #990

Open
2 tasks done
pavelzw opened this issue Dec 18, 2024 · 1 comment
Open
2 tasks done

Add PEP 639 license information to PypiPackageData #990

pavelzw opened this issue Dec 18, 2024 · 1 comment

Comments

@pavelzw
Copy link
Contributor

pavelzw commented Dec 18, 2024

Checklist

  • I added a descriptive title
  • I searched open requests and couldn't find a duplicate

What is the idea?

It would be nice to have the license information available in the PypiPackageData struct similar to how we have it in CondaPackageData as well.

https://peps.python.org/pep-0639/

Why is this needed?

needed for Quantco/conda-deny#25

What should happen?

No response

Additional Context

No response

@baszalmstra
Copy link
Collaborator

The reason we have the license information in the lock-file is not because its nice to have this information in the lock-file. We store it because in the matchspec language one could depend on the license of a package. E.g. rattler[license="BSD-3-Clause"]. Theoretically its part of the metadata that we need for the solver.

Its a pretty cool feature but also something I have never seen used. Regardless, to be fully compliant we need the information in the lock-file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants