Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Change header prop type on Tab to accept elements and strings #9

Open
MarvDann opened this issue Apr 26, 2019 · 1 comment
Open

Change header prop type on Tab to accept elements and strings #9

MarvDann opened this issue Apr 26, 2019 · 1 comment

Comments

@MarvDann
Copy link

MarvDann commented Apr 26, 2019

We want to be able to pass a component to the header property of the Tab component so that we can edit the title.

Would this be as simple as changing this in the interface?
interface TabProps { id: string; header: string | object; ...
or would it need to be React.ElementType rather than object?

@MarvDann MarvDann changed the title Change header prop type on Tab from string to string | object Change header prop type on Tab to accept elements and strings Apr 26, 2019
@markhepburn
Copy link
Contributor

Hi @MarvDann , thanks for your interest. It has been a while since I've touched this, but that seems perfectly reasonable -- do you fancy putting together a PR? :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants