Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequent Crashes on Hooking EndScene #5

Open
confessore opened this issue Feb 16, 2020 · 3 comments
Open

Frequent Crashes on Hooking EndScene #5

confessore opened this issue Feb 16, 2020 · 3 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@confessore
Copy link
Owner

frequent crashes occur when hooking the endscene

https://github.com/confessore/EluneBot/blob/master/src/EluneBot/Services/EndSceneService.cs

@confessore confessore self-assigned this Feb 16, 2020
@confessore confessore added bug Something isn't working help wanted Extra attention is needed labels Feb 16, 2020
@stobias123
Copy link

How does this crash show to the end user? I've forked and experience wowerror's often. Could those be related?

@confessore
Copy link
Owner Author

It has been a while since I loaded this up but I believe that a wow error occurs and then the wow crash window appears.
if I recall correctly, EndScene hooking is disabled by this line.
https://github.com/confessore/EluneBot/blob/master/src/EluneBot/Services/EndSceneService.cs#L14

the crashes you are experiencing are likely more related to the Object Manager and it's iterations while in a main city or after running for an extended period of time.

@stobias123
Copy link

Def related to reading memory, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants