Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for cri-o (peer-pods use case) #365

Closed
beraldoleal opened this issue Apr 25, 2024 · 1 comment
Closed

Improve support for cri-o (peer-pods use case) #365

beraldoleal opened this issue Apr 25, 2024 · 1 comment

Comments

@beraldoleal
Copy link
Member

Describe the bug
When using the operator to deploy peer-pods in a cri-o cluster, ccruntime-per-pods (as provided at samples folder) will fail because preInstall scripts are not ready for cri-o environments. Also the same sample uses :

- patch: |-
    - op: replace
      path: /spec/config/runtimeClasses
      value:
      - name: "kata-remote"
        snapshotter: "nydus"

Which is assuming containerd.

To Reproduce

  1. Install a cluster with crio.
  2. kubectl apply -k https://github.com/confidential-containers/operator/config/default
  3. kubectl apply -k https://github.com/confidential-containers/operator/config/samples/ccruntime/peer-pods

Describe the results you expected
No errors.

Describe the results you received:

$ kubectl logs pod/cc-operator-pre-install-daemon-nmmhs -n confidential-containers-system
INSTALL_COCO_CONTAINERD: false
INSTALL_OFFICIAL_CONTAINERD: false
INSTALL_VFIO_GPU_CONTAINERD: false
INSTALL_NYDUS_SNAPSHOTTER: true
ERROR: cri-o is not yet supported
@wainersm
Copy link
Member

wainersm commented Aug 6, 2024

This support has been added in #376

@wainersm wainersm closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants